Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs missing from Group after closing / restarting Firefox #62

Closed
Tyrewt opened this issue Jan 25, 2018 · 27 comments
Closed

Tabs missing from Group after closing / restarting Firefox #62

Tyrewt opened this issue Jan 25, 2018 · 27 comments

Comments

@Tyrewt
Copy link

Tyrewt commented Jan 25, 2018

Version 2.3.1 isn't restoring Tabs once Firefox is closed and then reopened. Upon reopening, Tabs appear to be intact for whichever group you left off on, however, the total number only states 1 when clicking the Simple Tab Group icon to view the Group list.

Additionally, whichever group is selected when you close Firefox and then reopen it, ALL Tabs will be lost, You will see that the total number of Tabs are reset down to 1 and completely gone for that group.

Firefox 58.

@Drive4ik
Copy link
Owner

You need to enable this in your browser settings
screenshot_2

@me21
Copy link

me21 commented Jan 25, 2018

It doesn't help. Tabs are restored but they do not belong to a group anymore.

@me21
Copy link

me21 commented Jan 25, 2018

Wait, it seems it works for me with version 2.3.1. Maybe it's version 2.3 that was buggy. I'll check one more time. Now, closing the Firefox...

@me21
Copy link

me21 commented Jan 25, 2018

...and reopening it. All tabs are currently in place.

@Drive4ik
Copy link
Owner

I'm glad that the problem was solved

@Tyrewt
Copy link
Author

Tyrewt commented Jan 26, 2018

This is NOT fixed. There are three outstanding issues.

"Show your windows and tabs from last time" is enabled.

Issue 1: Upon launching Firefox, note how in the current window (Group 1) there are 4 Tabs, yet the Tab Group menu on the top right counter only indicates "1".

screenshot from 2018-01-25 19-31-18

Issue 2: While Firefox is still open, I then switch to Group 2 which also has 4 Tabs, but the counter is correctly indicating 4 Tabs. I then close Firefox and launch again. Naturally once Firefox opens I am where I left off on Group 2. But, now the same issue outlined above affects Group 2. As you can see, the window has 4 Tabs present but the count on Group 2 is incorrectly indicating only 1.

screenshot from 2018-01-25 19-31-46

Issue 3: With the browser still open, I switch from Group 2 back over to Group 1, now the window only has 1 Tab and the count is reported correctly as 1. However, the other Tabs have been DELETED from the past session. This occurs on any Group you have selected when the browser is closed.

screenshot from 2018-01-25 19-31-56

I should also mention that Group 2 and Group 3 were imported using "Restore Quicksaver's Tab Groups" option, perhaps that has something to do with it?

Firefox 58 (64-Bit) for Ubuntu.

@me21
Copy link

me21 commented Jan 26, 2018

On the next day I have to confirm this is not fixed. After opening Firefox, I now have 1 tab in the current group, even though all tabs are open, but they don't belong to tab group anymore.

As a workaround, it is possible to backup tab groups before closing Firefox and restore as needed. But it is inconvenient, of course.

@me21
Copy link

me21 commented Jan 26, 2018

@Tyrewt @Drive4ik I've noticed that if I click on the inactive tab, it is reloaded and added to the tab group. Maybe that's helpful somehow.

@Drive4ik
Copy link
Owner

Hi all! can you please backup you tab groups, uninstall it and install this TEST build?
Notice:
rename this file from
test_simple_tab_groups-2.3.1-an+fx.xpi.zip
to
test_simple_tab_groups-2.3.1-an+fx.xpi

test_simple_tab_groups-2.3.1-an+fx.xpi.zip

and re-test this issue?

@Drive4ik Drive4ik reopened this Jan 26, 2018
@Drive4ik Drive4ik added the bug label Jan 26, 2018
@Drive4ik
Copy link
Owner

@Tyrewt please, can you retest too with this test addon build from prev message?

@meru448
Copy link

meru448 commented Jan 26, 2018

Tyrewt description much more accurately describes what I experienced, I don't know how to make the issue happen again, but I will uninstall & download the modified version.

@Drive4ik
Copy link
Owner

don't forget backup you data before uninstall!

@meru448
Copy link

meru448 commented Jan 26, 2018

Done, will proceed to use normally & post if the issue occurs again. // will this test version update automatically to 2.3.2 etc or should I keep an eye out for updates?

Many thanks btw, this addon, er extension as it were these days has been amazing.

Attempted to force the issue closing/reopening firefox, doing so on different groups & nothing yet, as I said I'm not really sure what the initial cause was as I had opened/closed firefox successfully many times before what Tyrewt described happened.

So, hopefully smooth sailing for now.

@Tyrewt
Copy link
Author

Tyrewt commented Jan 26, 2018

@Drive4ik Yes, I will evaluate the patch this evening. I'll report back with my findings as I now know how to replicate the issue(s), please keep open until then.

@Drive4ik
Copy link
Owner

No, this is test unstable version and you need to delete it.
If other users don't find any bugs I will update global version

@Drive4ik
Copy link
Owner

@Tyrewt , I can't close this issue until the problem is resolved.

Thanks for helping!

@Tyrewt
Copy link
Author

Tyrewt commented Jan 27, 2018

@Drive4ik Testing completed.

  1. A suggestion for improvement. Prior to uninstall I used the "Backup your Simple Tab Groups" option to create a backup. You should add a comment that indicates where the backup file is saved, currently it saves to the Downloads folder with no option to select a path and I was expecting it to be in with my Firefox profile.

  2. I have confirmed this TEST build corrects the issue(s) outlined in my bug report. All Tabs are intact and the Group counts are now accurate.

  3. While testing I've discovered a new issue Restore Quicksaver's "Tab Groups" option has trouble if Session Data included in backup #66

@me21
Copy link

me21 commented Jan 27, 2018

@Tyrewt 1. Depends on Firefox download settings. You can set it so that Firefox prompts for download location every time you save something.

I must add this bug doesn't happen every time I start Firefox. This time, for example, everything went fine, tabs were not lost.

@Drive4ik
Copy link
Owner

@Tyrewt thanks for testing)
@me21 thanks for testing too)

@Tyrewt go to browser settings and check this
screenshot_1

@me21
Copy link

me21 commented Jan 27, 2018

I didn't test, I wrote about version 2.3.1.

@Tyrewt
Copy link
Author

Tyrewt commented Jan 28, 2018

@Drive4ik Oh okay, thanks. I believe this issue is fixed with the TEST build.

@Drive4ik
Copy link
Owner

Please, re-test this issue in latest version v2.3.5

@me21
Copy link

me21 commented Jan 30, 2018

Updated to v2.3.6, no issues so far.

@Drive4ik
Copy link
Owner

Please, open this issue if it's replicated
Thanks

@Tyrewt
Copy link
Author

Tyrewt commented Jan 31, 2018

@Drive4ik Confirmed fixed - Tested 2.3.6. FYI, your work has on this Add-on has allowed me to finally upgrade to the latest Firefox, Simple Tab Groups is a direct replacement and ever BETTER than QucikSilver's Tab Group! Thank you for your contribution.

@me21
Copy link

me21 commented Feb 1, 2018

@Drive4ik Yeah, I fully agree with Tyrewt. Большое спасибо :-)

@Drive4ik
Copy link
Owner

Drive4ik commented Feb 1, 2018

@me21
Пожалуйста :)

Кстати, это оказался не простой баг а довольно серьезный:
https://bugzilla.mozilla.org/show_bug.cgi?id=1435077

там есть gif анимация


By the way, it was not just a bug but rather serious
there is gif animation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants